feat!: remove unstable_batchedUpdates, require React 19+ #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drops support for React 16, 17, and 18. Requires React 19+.
- Remove `import {unstable_batchedUpdates} from 'react-dom'`
- Remove `unstable_batchedUpdates()` wrapper in `doCallback()`
- Update comment to explain React 19+ automatic batching
- Update peerDependencies to require React 19
React 18+ introduced automatic batching for all state updates,
making `unstable_batchedUpdates` unnecessary. The React team has
indicated this API will be removed in a future version.
Closes rocicorp#56
renchris
force-pushed
the
feat/react-19-automatic-batching
branch
from
2df8c35 to
91749df
Compare
- Updated package.json to replace web-test-runner with vitest for testing. - Modified test scripts to use vitest commands. - Updated devDependencies to include vitest and related packages. - Refactored index.test.tsx to use vitest's expect and test functions. - Added vitest configuration file for browser testing setup. - Removed web-test-runner configuration file as it is no longer needed.
BREAKING CHANGE: Drops support for React 16, 17, and 18. Requires React 19+.
- Remove `import {unstable_batchedUpdates} from 'react-dom'`
- Remove `unstable_batchedUpdates()` wrapper in `doCallback()`
- Update comment to explain React 19+ automatic batching
- Update peerDependencies to require React 19
React 18+ introduced automatic batching for all state updates,
making `unstable_batchedUpdates` unnecessary. The React team has
indicated this API will be removed in a future version.
Closes rocicorp#56
Contributor
|
Closed by #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unstable_batchedUpdatesfromreact-dom- no longer needed with React 19's automatic batchingMotivation
React 18+ introduced automatic batching for all state updates, making
unstable_batchedUpdatesunnecessary.The React team has indicated this API will be removed in a future version. React 19 is now stable and
widely adopted, making this a good time to modernize the library.
References:
Changes
import {unstable_batchedUpdates} from 'react-dom'unstable_batchedUpdates()wrapper indoCallback()react ^19.0.0Breaking Changes
Test Plan
npm run check-types)npm run lint)unstable_batchedUpdatespreviously did)Note: The dev dependencies use React 17 ESM bundles (
@esm-bundle/react@^17). The batching test fails because React 17 doesn't have automatic batching. When the test infrastructure is updated to React 19, all tests will pass.